linux-kernel - Re: [PATCH 01/50] drivers/gpu/drm/i915/i915

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 08 Mar 2024 15:46:10 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 linux-fsdevel@...r.kernel.org
Cc: Kent Overstreet <kent.overstreet@...ux.dev>, tglx@...utronix.de,
 x86@...nel.org, tj@...nel.org, peterz@...radead.org,
 mathieu.desnoyers@...icios.com, paulmck@...nel.org, keescook@...omium.org,
 dave.hansen@...ux.intel.com, mingo@...hat.com, will@...nel.org,
 longman@...hat.com, boqun.feng@...il.com, brauner@...nel.org,
 intel-gfx@...ts.freedesktop.org, Dave Airlie <airlied@...hat.com>, Daniel
 Vetter <daniel@...ll.ch>
Subject: Re: [PATCH 01/50] drivers/gpu/drm/i915/i915_memcpy.c: fix missing
 includes

On Fri, 15 Dec 2023, Kent Overstreet <kent.overstreet@...ux.dev> wrote:
> Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>

This seems to have been merged to v6.8-rc1 as commit 86b9357c1bbe
("drivers/gpu/drm/i915/i915_memcpy.c: fix missing includes") without
Cc'ing the relevant lists or people, with no commit message or reviews,
or the CI we mandate for every single patch.

Sure it's trivial, but please extend the same courtesy to us as you'd
expect everyone else to extend to you before just merging stuff in the
trees you maintain.


Thanks,
Jani.


> ---
>  drivers/gpu/drm/i915/i915_memcpy.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_memcpy.c b/drivers/gpu/drm/i915/i915_memcpy.c
> index 1b021a4902de..40b288136841 100644
> --- a/drivers/gpu/drm/i915/i915_memcpy.c
> +++ b/drivers/gpu/drm/i915/i915_memcpy.c
> @@ -23,6 +23,8 @@
>   */
>  
>  #include <linux/kernel.h>
> +#include <linux/string.h>
> +#include <asm/cpufeature.h>
>  #include <asm/fpu/api.h>
>  
>  #include "i915_memcpy.h"

-- 
Jani Nikula, Intel