linux-kernel - Re: [PATCH 07/13] sched/balancing: Rename find_src_rq() => sched_balance_find_src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 8 Mar 2024 14:51:25 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Peter Zijlstra <peterz@...radead.org>, 
	Shrikanth Hegde <sshegde@...ux.ibm.com>, Valentin Schneider <vschneid@...hat.com>
Subject: Re: [PATCH 07/13] sched/balancing: Rename find_src_rq() => sched_balance_find_src_rq()

On Fri, 8 Mar 2024 at 12:18, Ingo Molnar <mingo@...nel.org> wrote:
>
> Standardize scheduler load-balancing function names on the
> sched_balance_() prefix.

This patch renames the renaming done by the previous one. They could
be merged in one

sched/balancing: Rename find_busiest_queue() => find_src_rq()
sched/balancing: Rename find_src_rq() => sched_balance_find_src_rq()



>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Shrikanth Hegde <sshegde@...ux.ibm.com>
> Cc: Valentin Schneider <vschneid@...hat.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> ---
>  kernel/sched/fair.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index e600cac7806d..1cd9a18b35e0 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -10959,9 +10959,9 @@ static struct sched_group *find_busiest_group(struct lb_env *env)
>  }
>
>  /*
> - * find_src_rq - find the busiest runqueue among the CPUs in the group.
> + * sched_balance_find_src_rq - find the busiest runqueue among the CPUs in the group.
>   */
> -static struct rq *find_src_rq(struct lb_env *env,
> +static struct rq *sched_balance_find_src_rq(struct lb_env *env,
>                                      struct sched_group *group)
>  {
>         struct rq *busiest = NULL, *rq;
> @@ -11280,7 +11280,7 @@ static int sched_balance_rq(int this_cpu, struct rq *this_rq,
>                 goto out_balanced;
>         }
>
> -       busiest = find_src_rq(&env, group);
> +       busiest = sched_balance_find_src_rq(&env, group);
>         if (!busiest) {
>                 schedstat_inc(sd->lb_nobusyq[idle]);
>                 goto out_balanced;
> --
> 2.40.1
>