linux-kernel - Re: [PATCH] ASoC: soc-pcm: add the judgment of unsupported commands for the function soc_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c78e86fe-5d0f-49dc-82f8-0e106618800a@sirena.org.uk>
Date: Fri, 8 Mar 2024 14:21:05 +0000
From: Mark Brown <broonie@...nel.org>
To: xuhanwu <2433926602@...com>
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	xu.hanwu@...lec.com
Subject: Re: [PATCH] ASoC: soc-pcm: add the judgment of unsupported commands
 for the function soc_pcm_trigger

On Fri, Mar 08, 2024 at 06:07:06PM +0800, xuhanwu wrote:

> Function soc_pcm_trigger, if the parameter cmd does not support the need to return an error (-EINVAL).

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> @@ -1173,6 +1173,9 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
>  			if (r < 0)
>  				break;
>  		}
> +		break;
> +	default:
> +		return -EINVAL;
>  	}

As can be seen from inspection of the immediately preceeding handling
of start, we're deliberately ignoring half the values in each switch.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)