linux-kernel - Re: [PATCH v3 0/6] Extra verbose/perf-list details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89249fc5-6102-45d4-9345-5dd80d06e001@linux.intel.com>
Date: Fri, 8 Mar 2024 10:39:27 -0500
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Yang Jihong <yangjihong1@...wei.com>, James Clark <james.clark@....com>,
 Ravi Bangoria <ravi.bangoria@....com>, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/6] Extra verbose/perf-list details



On 2024-03-07 7:19 p.m., Ian Rogers wrote:
> Add more encoding detail and raw event details in perf list. Add PMU
> name and reverse lookup from config to event name to
> perf_event_attr_fprintf. This makes the verbose output easier to read,
> and the perf list information more specific.
> 
> v3. Fix to reverse lookup to ensure or aliases are loaded and if
>     getting the config value fails for an event/alias just continue to
>     the next one.
> v2. Address feedback from Kan Liang, "Raw hardware event descriptor"
>     becomes "Raw event descriptor" add assert to keep term numbers in
>     sync, fix a commit message.
> 
> Ian Rogers (6):
>   perf list: Add tracepoint encoding to detailed output
>   perf pmu: Drop "default_core" from alias names
>   perf list: Allow wordwrap to wrap on commas
>   perf list: Give more details about raw event encodings
>   perf tools: Use pmus to describe type from attribute
>   perf tools: Add/use PMU reverse lookup from config to name

The patch series look good to me.
I verified it on a hybrid machine. The new format is the same as the
advertise.

Tested-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks,
Kan
> 
>  tools/perf/builtin-list.c                 | 21 ++++-
>  tools/perf/util/perf_event_attr_fprintf.c | 26 +++++--
>  tools/perf/util/pmu.c                     | 82 +++++++++++++++++++-
>  tools/perf/util/pmu.h                     |  4 +
>  tools/perf/util/pmus.c                    | 94 +++++++++++++++++++++++
>  tools/perf/util/pmus.h                    |  1 +
>  tools/perf/util/print-events.c            | 55 +++++++------
>  7 files changed, 242 insertions(+), 41 deletions(-)
>