[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <30c3773b-4db3-4278-a127-df8c075e8109@kernel.dk>
Date: Fri, 8 Mar 2024 10:18:06 -0700
From: Jens Axboe <axboe@...nel.dk>
To: John Garry <john.g.garry@...cle.com>, kbusch@...nel.org, hch@....de,
sagi@...mberg.me, jejb@...ux.ibm.com, martin.petersen@...cle.com,
djwong@...nel.org, viro@...iv.linux.org.uk, brauner@...nel.org,
dchinner@...hat.com, jack@...e.cz
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-nvme@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
tytso@....edu, jbongio@...gle.com, linux-scsi@...r.kernel.org,
ojaswin@...ux.ibm.com, linux-aio@...ck.org, linux-btrfs@...r.kernel.org,
io-uring@...r.kernel.org, nilay@...ux.ibm.com, ritesh.list@...il.com,
Prasad Singamsetty <prasad.singamsetty@...cle.com>
Subject: Re: [PATCH v5 03/10] fs: Initial atomic write support
On 3/8/24 10:15 AM, John Garry wrote:
> On 08/03/2024 17:05, Jens Axboe wrote:
>>> And the callers can hardcode rw_type?
>> Yep, basically making the change identical to the aio one. Not sure why
>> you did it differently in those two spots.
>
> In the aio code, rw_type was readily available. For io_uring it was
> not, and I chose to derive from something locally available. But
> that's a bit awkward and is not good for performance, so I'll follow
> your suggestion.
It's literally just one caller back, it's not like you had to look hard
to spot this. Don't take lazy shortcuts - it's not very confidence
inspiring if this is the level of attention to detail that went into
this patchset.
--
Jens Axboe
Powered by blists - more mailing lists