linux-kernel - Re: [PATCH v2 6/7] sparc32: Fix parport build with sparc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2403090906240.16468@angie.orcam.me.uk>
Date: Sat, 9 Mar 2024 09:06:47 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Andreas Larsson <andreas@...sler.com>
cc: sam@...nborg.org, sparclinux@...r.kernel.org, 
    Randy Dunlap <rdunlap@...radead.org>, 
    Miquel Raynal <miquel.raynal@...tlin.com>, 
    linux-parport@...ts.infradead.org, "David S. Miller" <davem@...emloft.net>, 
    Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org, 
    stable@...r.kernel.org
Subject: Re: [PATCH v2 6/7] sparc32: Fix parport build with sparc32

On Fri, 8 Mar 2024, Andreas Larsson wrote:

> > include/asm/parport.h is sparc64 specific.
> > Rename it to parport_64.h and use the generic version for sparc32.
> > 
> > This fixed all{mod,yes}config build errors like:
> > 
> > parport_pc.c:(.text):undefined-reference-to-ebus_dma_enable
> > parport_pc.c:(.text):undefined-reference-to-ebus_dma_irq_enable
> > parport_pc.c:(.text):undefined-reference-to-ebus_dma_register
> > 
> > The errors occur as the sparc32 build references sparc64 symbols.
> > 
> > Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Andreas Larsson <andreas@...sler.com>
> > Cc: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Maciej W. Rozycki <macro@...am.me.uk>
> > Closes: https://lore.kernel.org/r/20230406160548.25721-1-rdunlap@infradead.org/
> > Fixes: 66bcd06099bb ("parport_pc: Also enable driver for PCI systems")
> > Cc: stable@...r.kernel.org # v5.18+
> > ---
> >  arch/sparc/include/asm/parport.h    | 259 +-----------------------------------
> >  arch/sparc/include/asm/parport_64.h | 256 +++++++++++++++++++++++++++++++++++
> >  2 files changed, 263 insertions(+), 252 deletions(-)
> 
> Reviewed-by: Andreas Larsson <andreas@...sler.com>

Reviewed-by: Maciej W. Rozycki <macro@...am.me.uk>
Tested-by: Maciej W. Rozycki <macro@...am.me.uk> # build-tested

  Maciej