[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e70a3c8b-d7c6-418f-baad-fcc1414da3cd@linaro.org>
Date: Sat, 9 Mar 2024 13:11:10 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Théo Lebrun <theo.lebrun@...tlin.com>,
Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Vaishnav Achath <vaishnav.a@...com>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
Gregory CLEMENT <gregory.clement@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Tawfik Bayouk <tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH 01/11] dt-bindings: qspi: cdns,qspi-nor: add
mobileye,eyeq5-ospi compatible
On 08/03/2024 18:18, Théo Lebrun wrote:
> Add Mobileye EyeQ5 compatible.
> FIFO depth shall not be passed; hardware can detect it.
>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
There is no subsystem as "qspi". Also order of tags is incorrect.
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> ---
> Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> index cca81f89e252..cf7abf48673a 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> @@ -61,6 +61,17 @@ allOf:
> cdns,fifo-depth:
> enum: [ 128, 256 ]
> default: 128
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mobileye,eyeq5-ospi
> + then:
> + properties:
> + cdns,fifo-depth: false
> + else:
> + required:
> + - cdns,fifo-depth
>
> properties:
> compatible:
> @@ -74,6 +85,7 @@ properties:
> - xlnx,versal-ospi-1.0
> - intel,socfpga-qspi
> - starfive,jh7110-qspi
> + - mobileye,eyeq5-ospi
So everyone adds at the end...
Please put it after amd. With subject fixed and above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists