linux-kernel - Re: [PATCH v1 1/1] clk: fractional-divider: Move mask calculations out of lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfDNrDcLbBwHpn52qFEH=wFdnG1sx2jrU25oYJQ6OHGHA@mail.gmail.com>
Date: Sat, 9 Mar 2024 18:27:56 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v1 1/1] clk: fractional-divider: Move mask calculations
 out of lock

On Sat, Mar 9, 2024 at 9:19 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
> Le 03/03/2024 à 13:14, Andy Shevchenko a écrit :

..

> > @@ -195,14 +195,14 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate,
> >               n--;
> >       }
> >
> > +     mmask = GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> > +     nmask = GENMASK(fd->nwidth - 1, 0) << fd->nshift;

> if this is a hot path, you could maybe even compute:

It's not. set_rate() may be called only on disabled (and unprepared?)
clocks, which makes it already a too slow operation.

>     mask = ~(GENMASK(fd->mwidth - 1, 0) << fd->mshift |
>              GENMASK(fd->nwidth - 1, 0) << fd->nshift)
>
> unless gcc is smart enough to do it by itself.
>
> >       if (fd->lock)
> >               spin_lock_irqsave(fd->lock, flags);
> >       else
> >               __acquire(fd->lock);
> >
> > -     mmask = GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> > -     nmask = GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> > -
> >       val = clk_fd_readl(fd);
> >       val &= ~(mmask | nmask);
>
>     val &= mask;
>
> >       val |= (m << fd->mshift) | (n << fd->nshift);
>
> and pre-compute "(m << fd->mshift) | (n << fd->nshift)" outside of the
> lock too.

All of these sound to me as premature optimisations. I only wanted to
get back to the status quo.

-- 
With Best Regards,
Andy Shevchenko