linux-kernel - Re: [PATCH v9 04/15] x86/sgx: Implement basic EPC misc cgroup functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.2kdw36otwjvjmi@hhuan26-mobl.amr.corp.intel.com>
Date: Sat, 09 Mar 2024 15:10:44 -0600
From: "Haitao Huang" <haitao.huang@...ux.intel.com>
To: Michal Koutný <mkoutny@...e.com>, "Haitao Huang"
 <haitao.huang@...ux.intel.com>
Cc: jarkko@...nel.org, dave.hansen@...ux.intel.com, tj@...nel.org,
 linux-kernel@...r.kernel.org, linux-sgx@...r.kernel.org, x86@...nel.org,
 cgroups@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 hpa@...or.com, sohil.mehta@...el.com, tim.c.chen@...ux.intel.com,
 zhiquan1.li@...el.com, kristen@...ux.intel.com, seanjc@...gle.com,
 zhanb@...rosoft.com, anakrish@...rosoft.com, mikko.ylinen@...ux.intel.com,
 yangjie@...rosoft.com, chrisyan@...rosoft.com
Subject: Re: [PATCH v9 04/15] x86/sgx: Implement basic EPC misc cgroup
 functionality

On Tue, 27 Feb 2024 15:35:38 -0600, Haitao Huang  
<haitao.huang@...ux.intel.com> wrote:

> On Mon, 26 Feb 2024 12:25:58 -0600, Michal Koutný <mkoutny@...e.com>  
> wrote:
>
>> On Mon, Feb 05, 2024 at 01:06:27PM -0800, Haitao Huang  
>> <haitao.huang@...ux.intel.com> wrote:
>>> +static int sgx_epc_cgroup_alloc(struct misc_cg *cg);
>>> +
>>> +const struct misc_res_ops sgx_epc_cgroup_ops = {
>>> +	.alloc = sgx_epc_cgroup_alloc,
>>> +	.free = sgx_epc_cgroup_free,
>>> +};
>>> +
>>> +static void sgx_epc_misc_init(struct misc_cg *cg, struct  
>>> sgx_epc_cgroup *epc_cg)
>>> +{
>>> +	cg->res[MISC_CG_RES_SGX_EPC].priv = epc_cg;
>>> +	epc_cg->cg = cg;
>>> +}
>>
>> This is a possibly a nit pick but I share it here for consideration.
>>
>> Would it be more prudent to have the signature like
>>   alloc(struct misc_res *res, struct misc_cg *cg)
>> so that implementations are free of the assumption of how cg and res are
>> stored?
>>
>>
>> Thanks,
>> Michal
>
> Will do.
>
> Thanks
> Haitao
>
Actually, because the root node is initialized in sgx_cgroup_init(), which  
only has access to misc_cg_root() so we can't pass a misc_res struct  
without knowing cg->res relationship. We could hide it with a getter, but  
I think it's a little overkill at the moment. I can sign up for adding  
this improvement if we feel it needed in future.

Thanks
Haitao