linux-kernel - [GIT PULL] firewire fixes for v6.8-final

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Sat, 9 Mar 2024 13:01:42 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: torvalds@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, edmund.raile@...ton.me
Subject: [GIT PULL] firewire fixes for v6.8-final

Hi Linus,

Please accept this PR to your tree. It includes a bug fix relevant to an
allocated IRQ in PCI driver for 1394 OHCI hardware. The bug appears in
kernel v6.5 or later, therefore I expect the maintainers to apply the
fix to stable and longterm kernels as well.

The following changes since commit 90d35da658da8cff0d4ecbb5113f5fac9d00eb72:

  Linux 6.8-rc7 (2024-03-03 13:02:52 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git tags/firewire-fixes-6.8-final

for you to fetch changes up to 575801663c7dc38f826212b39e3b91a4a8661c33:

  firewire: ohci: prevent leak of left-over IRQ on unbind (2024-03-06 22:35:22 +0900)

----------------------------------------------------------------
firewire-fixes-6.8-final

A fix to suppress warning about unreleased IRQ for 1394 OHCI hardware when
disabling MSI

In Linux kernel v6.5, a PCI driver for 1394 OHCI hardware was optimized
into the managed device resources. Edmund Raile points out that the change
brings the warning about unreleased IRQ at the call of pci_disable_msi(),
since the API expects that the relevant IRQ has already been released in
advance.

As long as the API is called in .remove callback of PCI device operation,
it is prohibited to maintain the IRQ as the part of managed device
resource. As a workaround, the IRQ is explicitly released at .remove
callback, before the call of pci_disable_msi().

The pci_disable_msi() is legacy API nowadays in PCI MSI implementation. I
have a plan to replace it with the modern API in the development for the
future version of Linux kernel. So at present I keep them as is.

----------------------------------------------------------------
Edmund Raile (1):
      firewire: ohci: prevent leak of left-over IRQ on unbind

 drivers/firewire/ohci.c | 2 ++
 1 file changed, 2 insertions(+)

Thanks

Takashi Sakamoto