linux-kernel - Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org>
Date: Fri, 8 Mar 2024 20:36:41 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Barry Song <21cnbao@...il.com>
Cc: herbert@...dor.apana.org.au, chriscli@...gle.com, chrisl@...nel.org,
 ddstreet@...e.org, linux-kernel@...r.kernel.org, sjenning@...hat.com,
 vitaly.wool@...sulko.com, Barry Song <v-songbaohua@...o.com>,
 davem@...emloft.net, hannes@...xchg.org, linux-crypto@...r.kernel.org,
 linux-mm@...ck.org, zhouchengming@...edance.com, nphamcs@...il.com,
 yosryahmed@...gle.com
Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not
 sleepable

On Sat, 9 Mar 2024 11:58:39 +0800 Barry Song <21cnbao@...il.com> wrote:

> > >
> > > So it should be quite safe to pull this series into mm-tree now.
> >
> > But this zswap chage requires the presence of the other patches, yes?
> 
> As far as I understand, we rely on two driver fixes because those drivers didn't
> set the correct cra_flags needed by our patch1. Without those fixes implemented,
> two platforms might encounter issues: Intel with IAA (Intel Analytics
> Accelerator)
> and Hisilicon with ZIP. Other platforms should be unaffected.
> 
> The two driver fixes have been merged into the crypto tree.
> 
> >
> > So the mm.git tree alone will be buggy?  And if mm.git merges ahead of
> > the other trees, there will be a window where mainline will be buggy?
> 
> Before 6.9-rc1, there might be issues if mm enters Linus' tree before Herbert's
> crypto tree. However, by 6.9-rc1, everything should be fine.
> 
> >
> > If so, I think it wuold be better to merge the zswap patch in the next
> > merge window.
> >
> 
> Okay, I understand. Since this patch improves zswap's performance, I wanted
> it to be integrated sooner to contribute. However, I'm perfectly willing to
> respect your concerns and adhere to the community's best practices.
> 

OK.  I very much doubt if anyone is running those drivers on mm.git, so
adding it now isn't likely to hurt.

So I'll merge it now and shall aim to get it upstream very late in the
next merge window.