linux-kernel - Re: [PATCH v2 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator outside soc dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240310101005.13541-1-amadeus@jmu.edu.cn>
Date: Sun, 10 Mar 2024 18:10:05 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: dmitry.baryshkov@...aro.org
Cc: amadeus@....edu.cn,
	andersson@...nel.org,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	konrad.dybcio@...aro.org,
	krzysztof.kozlowski+dt@...aro.org,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	robh@...nel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator outside soc dtsi

Hi, Dmitry
> Please inline this dtsi file into the board file. While it might seem
> to make life easier, having such includes makes following regulator
> settings much harder. Especially once a board or two start overriding
> or expanding those settings.

Thanks for your suggestion. But unlike mobile phones or dev boards,
I don't think any manufacturer will change the voltage settings of
the mp5496 pmic on the ipq60xx router. The s2 part of mp5496 pmic
is used to supply the CPU, and its min/max voltage corresponds to
the CPU frequency of ipq60xx. Although the downstream qsdk kernel
uses the cpr regulator driver, its min/max voltage is still the
same as the current setting.

Thanks,
Chukun

-- 
2.25.1