[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Ze4W4bEwdNET0188@google.com>
Date: Sun, 10 Mar 2024 13:24:01 -0700
From: Igor Pylypiv <ipylypiv@...gle.com>
To: John Garry <john.g.garry@...cle.com>
Cc: jejb@...ux.ibm.com, martin.petersen@...cle.com,
chenxiang66@...ilicon.com, jinpu.wang@...ud.ionos.com,
artur.paszkiewicz@...el.com, yanaijie@...wei.com,
dlemoal@...nel.org, cassel@...nel.org, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE
On Fri, Mar 08, 2024 at 11:43:38AM +0000, John Garry wrote:
> Use standard template for scsi_host_template structure to reduce
> duplication.
>
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
> drivers/scsi/mvsas/mv_init.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
Reviewed-by: Igor Pylypiv <ipylypiv@...gle.com>
Thanks,
Igor
>
> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
> index 43ebb331e216..fb81d267c9cc 100644
> --- a/drivers/scsi/mvsas/mv_init.c
> +++ b/drivers/scsi/mvsas/mv_init.c
> @@ -30,28 +30,11 @@ static const struct attribute_group *mvst_host_groups[];
> #define SOC_SAS_NUM 2
>
> static const struct scsi_host_template mvs_sht = {
> - .module = THIS_MODULE,
> - .name = DRV_NAME,
> - .queuecommand = sas_queuecommand,
> - .dma_need_drain = ata_scsi_dma_need_drain,
> - .target_alloc = sas_target_alloc,
> - .slave_configure = sas_slave_configure,
> + LIBSAS_SHT_BASE
> .scan_finished = mvs_scan_finished,
> .scan_start = mvs_scan_start,
> - .change_queue_depth = sas_change_queue_depth,
> - .bios_param = sas_bios_param,
> .can_queue = 1,
> - .this_id = -1,
> .sg_tablesize = SG_ALL,
> - .max_sectors = SCSI_DEFAULT_MAX_SECTORS,
> - .eh_device_reset_handler = sas_eh_device_reset_handler,
> - .eh_target_reset_handler = sas_eh_target_reset_handler,
> - .slave_alloc = sas_slave_alloc,
> - .target_destroy = sas_target_destroy,
> - .ioctl = sas_ioctl,
> -#ifdef CONFIG_COMPAT
> - .compat_ioctl = sas_ioctl,
> -#endif
> .shost_groups = mvst_host_groups,
> .track_queue_depth = 1,
> };
> --
> 2.31.1
>
Powered by blists - more mailing lists