linux-kernel - Re: [PATCH v7 7/7] mtd: ubi: provide NVMEM layer over UBI volumes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 10 Mar 2024 22:17:17 +0100 (CET)
From: Richard Weinberger <richard@....at>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, 
	Vignesh Raghavendra <vigneshr@...com>, 
	Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Conor Dooley <conor+dt@...nel.org>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 7/7] mtd: ubi: provide NVMEM layer over UBI volumes

Daniel,

----- Ursprüngliche Mail -----
> Von: "Daniel Golle" <daniel@...rotopia.org>
>> Finally(!), I had enough time to look.
>> Thanks for addressing all my comments form the previous series.
>> Patches applied.
> 
> It's an enourmous coicident that you are writing just now that I found
> a sizeof(int)-related problem which triggers a compiler warning when
> building the UBI NVMEM provider on 32-bit platforms. I was just about
> to prepare an updated series. Literally in this minute.
> Should I still send the whole updates series or only the final patch
> (as the necessary change is there) or a follow-up patch fixing the
> original patch?

I have just merged your fixup patch. So all good.

>> 
>> I have only one tiny request, can you share the lockdep spalt
>> you encountered in ubi_notify_add() regarding mtd_table_mutex
>> and ubi_devices_mutex? The solutions looks okay to me, but
>> if you have more details that would be great.
> 
> I will setup a test build to reproduce the original warning and
> let you know shortly.

Any news on that?

BTW: Is there a nice way to test this with nandsim in qemu?
I'd love being able to test all ubi attach code paths on my test setup.

Thanks,
//richard