linux-kernel - Re: [PATCH] Fix typo in reporting-regressions.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd766a41-4dfa-4f57-8af2-163023acbead@leemhuis.info>
Date: Sun, 10 Mar 2024 08:57:55 +0100
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Chris Bainbridge <chris.bainbridge@...il.com>
Cc: regressions@...ts.linux.dev, trivial@...nel.org,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Linux Doc Mailing List <linux-doc@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix typo in reporting-regressions.rst

[CCing Nícolas]

On 07.03.24 19:10, Chris Bainbridge wrote:

First off: many thx for this, much appreciated!

> Append a ':' character to the first usage of "#regzbot introduced".

FWIW, that is obvious and not needed here; but having it in the subject
would be good. The subject also does not really match the expected
style. But let's ignore that for now due the aspect mentioned below.

> According to the regzbot documentation, the ':' suffix is the correct
> format, and, even if not strictly necessary, it is good to be
> consistent.

Sadly a slightly tricky situation developed coincidentally: Nícolas not
even 24 hours later send a patch that fixes this as well, but does so in
a related document as well, which is wise:
https://lore.kernel.org/all/20240308-regzbot-fixes-v1-1-577a4fe16e12@collabora.com/

Which leads to the question: how much do you care that you patch makes
it in? If you would like to have a fresh commit in the kernel (which is
totally valid thing to want!) we definitely could improve your
submission and then adjust Nícolas changes on top of it -- but if you
don't care at all we could just directly take Nícolas patch.

Ciao, Thorsten