linux-kernel - Re: [PATCH 09/13] sched/balancing: Rename update_blocked_averages() => sched_balance_update_blocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5687abb-cab7-497d-a997-572358d3807b@126.com>
Date: Mon, 11 Mar 2024 14:42:55 +0800
From: Honglei Wang <jameshongleiwang@....com>
To: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Cc: Dietmar Eggemann <dietmar.eggemann@....com>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Peter Zijlstra <peterz@...radead.org>,
 Shrikanth Hegde <sshegde@...ux.ibm.com>,
 Valentin Schneider <vschneid@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 09/13] sched/balancing: Rename update_blocked_averages()
 => sched_balance_update_blocked_averages()



On 2024/3/8 19:18, Ingo Molnar wrote:
> Standardize scheduler load-balancing function names on the
> sched_balance_() prefix.
> 
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Shrikanth Hegde <sshegde@...ux.ibm.com>
> Cc: Valentin Schneider <vschneid@...hat.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> ---
>   kernel/sched/fair.c | 8 ++++----
>   kernel/sched/pelt.c | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 96a81b2fa281..95f7092043f3 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9411,7 +9411,7 @@ static unsigned long task_h_load(struct task_struct *p)
>   }
>   #endif
>   
> -static void update_blocked_averages(int cpu)
> +static void sched_balance_update_blocked_averages(int cpu)
>   {
>   	bool decayed = false, done = true;
>   	struct rq *rq = cpu_rq(cpu);
> @@ -12079,7 +12079,7 @@ static bool update_nohz_stats(struct rq *rq)
>   	if (!time_after(jiffies, READ_ONCE(rq->last_blocked_load_update_tick)))
>   		return true;
>   
> -	update_blocked_averages(cpu);
> +	sched_balance_update_blocked_averages(cpu);
>   
>   	return rq->has_blocked_load;
>   }
> @@ -12339,7 +12339,7 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf)
>   	raw_spin_rq_unlock(this_rq);
>   
>   	t0 = sched_clock_cpu(this_cpu);
> -	update_blocked_averages(this_cpu);
> +	sched_balance_update_blocked_averages(this_cpu);
>   
>   	rcu_read_lock();
>   	for_each_domain(this_cpu, sd) {
> @@ -12431,7 +12431,7 @@ static __latent_entropy void sched_balance_softirq(struct softirq_action *h)
>   		return;
>   
>   	/* normal load balance */
> -	update_blocked_averages(this_rq->cpu);
> +	sched_balance_update_blocked_averages(this_rq->cpu);
>   	sched_balance_domains(this_rq, idle);
>   }
>   
> diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
> index 63b6cf898220..f80955ecdce6 100644
> --- a/kernel/sched/pelt.c
> +++ b/kernel/sched/pelt.c
> @@ -209,7 +209,7 @@ ___update_load_sum(u64 now, struct sched_avg *sa,
>   	 * This means that weight will be 0 but not running for a sched_entity
>   	 * but also for a cfs_rq if the latter becomes idle. As an example,
>   	 * this happens during idle_balance() which calls

Could we also fix this ghost idle_balance() in this serial (maybe in 
patch 10)?

Honglei
> -	 * update_blocked_averages().
> +	 * sched_balance_update_blocked_averages().
>   	 *
>   	 * Also see the comment in accumulate_sum().
>   	 */