linux-kernel - Re: [PATCH 1/1] platform/surface: platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 11 Mar 2024 18:32:30 -0400
From: Ivor Wanders <ivor@...nders.net>
To: ilpo.jarvinen@...ux.intel.com
Cc: hdegoede@...hat.com,
	ivor@...nders.net,
	linux-kernel@...r.kernel.org,
	luzmaximilian@...il.com,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 1/1] platform/surface: platform_profile: add fan profile switching

> Is char correct type here or do you perhaps mean e.g., u8 that is more 
approriate for 1-byte long binary data? [...] u8 ?

Thanks for the review Ilpo. Agreed, u8 would be better, I also noticed that
this variable, and the profile_le one in the function just above it can be
const, I'll change this type to u8 and make both profile variable const in v2.

~Ivor