linux-kernel - Re: [PATCH] staging: p80211conv: Rename local foo to decrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ze+JxSpqc/eHfCKn@aschofie-mobl2>
Date: Mon, 11 Mar 2024 15:46:29 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: "Felix N. Kimbu" <felixkimbu1@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check

On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote:
> This change renames the local variable foo to decrypt_check in functions
> skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive
> meaning to the identifier.

'rc' is typically used for cases like this. If the name of the function
being called is reasonably intuitive, then 'rc' suffices for the return
value.

> 
> It also indents the parameters to match the the opening parentheses.

'Also' signals that this patch is trying to do more than one thing.
One type of 'thing' per patch please.

The commit message prefixes are off. Please see First Patch Tutorial
Section: "Following the Driver commit style"

Patch fails checkpatch. Please see First Patch Tutorial Sections:
"Git post-commit hooks" and "Understand patch best practices"

--snip