linux-kernel - Re: [PATCH v2 4/4] ASoC: fsl: imx-rpmsg: Update to correct DT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2c9a841-9ed1-4925-b6cd-16cdef36f279@kernel.org>
Date: Mon, 11 Mar 2024 08:48:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chancel Liu <chancel.liu@....com>,
 "shengjiu.wang@...il.com" <shengjiu.wang@...il.com>,
 "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>,
 "festevam@...il.com" <festevam@...il.com>,
 "nicoleotsuka@...il.com" <nicoleotsuka@...il.com>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>,
 "broonie@...nel.org" <broonie@...nel.org>, "perex@...ex.cz"
 <perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 dl-linux-imx <linux-imx@....com>,
 "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
 "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/4] ASoC: fsl: imx-rpmsg: Update to correct DT node

On 11/03/2024 08:33, Chancel Liu wrote:
>>> @@ -127,6 +126,22 @@ static int imx_rpmsg_probe(struct platform_device
>> *pdev)
>>>               goto fail;
>>>       }
>>>
>>> +     if (!strcmp(pdev->dev.platform_data, "rpmsg-micfil-channel"))
>>> +             np = of_find_node_by_name(NULL, "rpmsg_micfil");
>>> +     else
>>> +             np = of_find_node_by_name(NULL, "rpmsg_audio");
>>
>> Why do you create ABI on node names? Where is it documented? Why can't
>> you use phandles?
>>
>> Best regards,
>> Krzysztof
> 
> Thanks for your reminder. Truly I shouldn't use undocumented bindings. I will
> use “fsl,rpmsg-channel-name” to refine patch set. Please help review next
> version.

Instead of hard-coding node names in the driver you want to put it in
"fsl,rpmsg-channel-name" property? I don't follow. I recommended instead
using phandles, care to address that?

Best regards,
Krzysztof