linux-kernel - Re: [PATCH] perf: RISC-V: fix IRQ detection on T-Head C908

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALW65jZ+q8sDiRKgsRL9n+939HNUCnkKuO=YJjHB5Js=WYQeOg@mail.gmail.com>
Date: Mon, 11 Mar 2024 15:56:29 +0800
From: Qingfang Deng <dqfext@...il.com>
To: Inochi Amaoto <inochiama@...look.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Atish Patra <atishp@...shpatra.org>, 
	Anup Patel <anup@...infault.org>, Will Deacon <will@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Andrew Jones <ajones@...tanamicro.com>, 
	Conor Dooley <conor.dooley@...rochip.com>, Heiko Stuebner <heiko@...ech.de>, 
	Guo Ren <guoren@...nel.org>, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] perf: RISC-V: fix IRQ detection on T-Head C908

Hi Inochi,

On Mon, Mar 11, 2024 at 3:13 PM Inochi Amaoto <inochiama@...look.com> wrote:
>
> On Mon, Mar 11, 2024 at 02:30:18PM +0800, Qingfang Deng wrote:
> > T-Head C908 has the same IRQ num and CSR as previous C9xx cores, but
> > reports non-zero marchid and mimpid. Remove the ID checks.
> >
>
> Hi, Qingfang,
>
> IIRC, the existed C908 SoC (such as K230) have an early version
> of C908 core. But C908 core itself may support Sscofpmf.
> So I do not think removing the ID checks is a good idea. Instead,
> I suggest adding CPUID of your SoC to this check.

As of Feb 2024, the latest C908 revision does not support Sscofpmf.
You may Google "C908R1S0" to see its user manual.
But I think you're right. Even though C908 does not have Sscofpmf,
T-Head may release new SoCs which do have Sscofpmf, and the check will
break. I will submit a new patch with your suggested changes.

Regards,
Qingfang
>
> Regards,
> Inochi
>