linux-kernel - Re: [PATCH] riscv: Remove unused asm/signal.h file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 11 Mar 2024 16:30:20 +0800
From: Guo Ren <guoren@...nel.org>
To: Stafford Horne <shorne@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Björn Töpel <bjorn@...osinc.com>, 
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] riscv: Remove unused asm/signal.h file

On Sun, Mar 10, 2024 at 7:21 PM Stafford Horne <shorne@...il.com> wrote:
>
> When riscv moved to common entry the definition and usage of
> do_work_pending was removed.  This unused header file remains.
>
> Remove the header file as it is not used.
>
> I have tested compiling the kernel with this patch applied and saw no
> issues.  Noticed when auditing how different ports handle signals
> related to saving FPU state.
>
> Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> Signed-off-by: Stafford Horne <shorne@...il.com>
> ---
>  arch/riscv/include/asm/signal.h | 12 ------------
>  1 file changed, 12 deletions(-)
>  delete mode 100644 arch/riscv/include/asm/signal.h
>
> diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
> deleted file mode 100644
> index 956ae0a01bad..000000000000
> --- a/arch/riscv/include/asm/signal.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -
> -#ifndef __ASM_SIGNAL_H
> -#define __ASM_SIGNAL_H
> -
> -#include <uapi/asm/signal.h>
> -#include <uapi/asm/ptrace.h>
> -
> -asmlinkage __visible
> -void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
No more calling in arch/riscv for do_work_pending.

> -
> -#endif
> --
> 2.41.0
>
LGTM, Thx.

Reviewed-by: Guo Ren <guoren@...nel.org>

-- 
Best Regards
 Guo Ren