[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<DB9PR04MB9377D462E168D03012B3405FE1242@DB9PR04MB9377.eurprd04.prod.outlook.com>
Date: Mon, 11 Mar 2024 08:57:01 +0000
From: Joy Zou <joy.zou@....com>
To: Marco Felsch <m.felsch@...gutronix.de>
CC: Jacky Bai <ping.bai@....com>, "lgirdwood@...il.com" <lgirdwood@...il.com>,
"broonie@...nel.org" <broonie@...nel.org>, "robh+dt@...nel.org"
<robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>,
"kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
<festevam@...il.com>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v2 3/3] arm64: dts: imx93-11x11-evk: add
pca9451a support
> -----Original Message-----
> From: Marco Felsch <m.felsch@...gutronix.de>
> Sent: 2024年3月11日 16:52
> To: Joy Zou <joy.zou@....com>
> Cc: Jacky Bai <ping.bai@....com>; lgirdwood@...il.com;
> broonie@...nel.org; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
> devicetree@...r.kernel.org; imx@...ts.linux.dev; linux-kernel@...r.kernel.org;
> dl-linux-imx <linux-imx@....com>; kernel@...gutronix.de;
> festevam@...il.com; linux-arm-kernel@...ts.infradead.org
> Subject: [EXT] Re: [PATCH v2 3/3] arm64: dts: imx93-11x11-evk: add
> pca9451a support
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> Hi,
>
> On 24-03-11, Joy Zou wrote:
> > Support pca9451a on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@....com>
> > ---
> > .../boot/dts/freescale/imx93-11x11-evk.dts | 112
> ++++++++++++++++++
> > 1 file changed, 112 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 9921ea13ab48..6cb5b7d745bf 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -183,6 +183,105 @@ &wdog3 {
> > status = "okay";
> > };
> >
> > +&lpi2c2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <400000>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&pinctrl_lpi2c2>;
> > + pinctrl-1 = <&pinctrl_lpi2c2>;
> > + status = "okay";
> > +
> > + pmic@25 {
> > + compatible = "nxp,pca9451a";
> > + reg = <0x25>;
> > + interrupt-parent = <&pcal6524>;
> > + interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
> > +
> > + regulators {
> > + buck1: BUCK1 {
> > + regulator-name = "BUCK1";
> > + regulator-min-microvolt = <650000>;
> > + regulator-max-microvolt = <2237500>;
>
> Can you please check you limits with the EE department? The constraints in a
> DTS file should reflect the board constraints and not the PMIC contraints.
Okay, I will check and modify the constraints.
Thank you very much!
BR
Joy Zou
>
> Regards,
> Marco
>
> > + regulator-boot-on;
> > + regulator-always-on;
> > + regulator-ramp-delay = <3125>;
> > + };
> > +
> > + buck2: BUCK2 {
> > + regulator-name = "BUCK2";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <2187500>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + regulator-ramp-delay = <3125>;
> > + };
> > +
> > + buck4: BUCK4{
> > + regulator-name = "BUCK4";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <3400000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + buck5: BUCK5{
> > + regulator-name = "BUCK5";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <3400000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + buck6: BUCK6 {
> > + regulator-name = "BUCK6";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <3400000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo1: LDO1 {
> > + regulator-name = "LDO1";
> > + regulator-min-microvolt = <1600000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo4: LDO4 {
> > + regulator-name = "LDO4";
> > + regulator-min-microvolt = <800000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + ldo5: LDO5 {
> > + regulator-name = "LDO5";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > + };
> > + };
> > +
> > + pcal6524: gpio@22 {
> > + compatible = "nxp,pcal6524";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_pcal6524>;
> > + reg = <0x22>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
> > + };
> > +
> > +};
> > +
> > &iomuxc {
> > pinctrl_eqos: eqosgrp {
> > fsl,pins = <
> > @@ -239,6 +338,19 @@ MX93_PAD_DAP_TCLK_SWCLK__LPUART5_CTS_B
> 0x31e
> > };
> >
> > /* need to config the SION for data and cmd pad, refer to
> > ERR052021 */
> > + pinctrl_lpi2c2: lpi2c2grp {
> > + fsl,pins = <
> > + MX93_PAD_I2C2_SCL__LPI2C2_SCL
> 0x40000b9e
> > + MX93_PAD_I2C2_SDA__LPI2C2_SDA
> 0x40000b9e
> > + >;
> > + };
> > +
> > + pinctrl_pcal6524: pcal6524grp {
> > + fsl,pins = <
> > + MX93_PAD_CCM_CLKO2__GPIO3_IO27
> 0x31e
> > + >;
> > + };
> > +
> > pinctrl_usdhc1: usdhc1grp {
> > fsl,pins = <
> > MX93_PAD_SD1_CLK__USDHC1_CLK
> 0x15fe
> > --
> > 2.37.1
> >
> >
> >
Powered by blists - more mailing lists