linux-kernel - Re: [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CZQSPYZUWFGD.1ZLSA295LSM77@bootlin.com>
Date: Mon, 11 Mar 2024 09:59:36 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Andi Shyti" <andi.shyti@...nel.org>
Cc: "Linus Walleij" <linus.walleij@...aro.org>, "Rob Herring"
 <robh+dt@...nel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@...aro.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-mips@...r.kernel.org>, "Gregory Clement"
 <gregory.clement@...tlin.com>, "Vladimir Kondratiev"
 <vladimir.kondratiev@...ileye.com>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C
 controller

Hello,

On Fri Mar 8, 2024 at 11:54 PM CET, Andi Shyti wrote:
> Hi Theo,
>
> > +static inline void nmk_i2c_writeb(const struct nmk_i2c_dev *priv, u32 val,
> > +				unsigned long reg)
>
> If you don't mind, I fixed this checkpatch warning while
> applying:
>
> CHECK: Alignment should match open parenthesis
> #103: FILE: drivers/i2c/busses/i2c-nomadik.c:247:
> +static inline void nmk_i2c_writeb(const struct nmk_i2c_dev *priv, u32 val,
> +                               unsigned long reg)

Indeed I do not mind. Thanks for the work!
Do ping me if any follow-up is required.

Regards,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com