[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJfpegtQSi0GFzUEDqdeOAq7BN2KvDV8i3oBFvPOCKfJJOBd2g@mail.gmail.com>
Date: Mon, 11 Mar 2024 10:25:20 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Luis Henriques <lhenriques@...e.de>
Cc: "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>,
Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
Amir Goldstein <amir73il@...il.com>, linux-ext4@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-unionfs@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] ovl: fix the parsing of empty string mount parameters
On Thu, 7 Mar 2024 at 19:17, Luis Henriques <lhenriques@...e.de> wrote:
>
> This patch fixes the usage of mount parameters that are defined as strings
> but which can be empty. Currently, only 'lowerdir' parameter is in this
> situation for overlayfs. But since userspace can pass it in as 'flag'
> type (when it doesn't have a value), the parsing will fail because a
> 'string' type is assumed.
I don't really get why allowing a flag value instead of an empty
string value is fixing anything.
It just makes the API more liberal, but for what gain?
Thanks,
Miklos
Powered by blists - more mailing lists