linux-kernel - Re: [PATCH] scsi: megaraid_sas: disabled shared host tagset feature by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03afee77-3d5e-44fc-9e03-eec70c9cee2a@oracle.com>
Date: Mon, 11 Mar 2024 09:30:36 +0000
From: John Garry <john.g.garry@...cle.com>
To: mengfanhui <mengfanhui@...inos.cn>, kashyap.desai@...adcom.com,
        sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com,
        chandrakanth.patil@...adcom.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: megaraid_sas: disabled shared host tagset feature
 by default

On 11/03/2024 08:54, mengfanhui wrote:
> By default, the host_tagset_enable feature is disabled，Fio performance
> has improved significantly
> 
> fio test command:
> sudo fio -filename=/fio_test -direct=1 -iodepth 32 -thread -rw=write -ioengine=libaio
> -bs=4K -size=5120M -runtime=600 -numjobs=$CPUN -group_reporting -name=**.result >> **.result
> 
> The test data results bw  are as follows：
>                v6.8_kernel       v6.8_kernel_disable_host_tagset
> 4k randwrite     375                     642
> 4k randread      210                     784
> 4k  write        306                     387
> 4k  read         435                     2457
> 128k write       355                     380
> 128k read        976                     3665
> 1M   read        415                     3122
> 

There are some huge differences in those numbers. Can you find out what 
is going on?

> Signed-off-by: mengfanhui <mengfanhui@...inos.cn>
> ---
>   drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 3d4f13da1ae8..da19c4c07f2f 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -123,9 +123,9 @@ MODULE_PARM_DESC(poll_queues, "Number of queues to be use for io_uring poll mode
>   		"High iops queues are not allocated &\n\t\t"
>   		);
>   
> -int host_tagset_enable = 1;
> +int host_tagset_enable;
>   module_param(host_tagset_enable, int, 0444);
> -MODULE_PARM_DESC(host_tagset_enable, "Shared host tagset enable/disable Default: enable(1)");
> +MODULE_PARM_DESC(host_tagset_enable, "Shared host tagset enable/disable Default: disable(0)");
>   
>   MODULE_LICENSE("GPL");
>   MODULE_VERSION(MEGASAS_VERSION);