linux-kernel - Re: [PATCH v9 0/5] Support for Avago APDS9306 Ambient Light Sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ze7UQAD4V3n-MKDJ@smile.fi.intel.com>
Date: Mon, 11 Mar 2024 11:52:00 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Marek Vasut <marex@...x.de>, Anshul Dalal <anshulusr@...il.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Matt Ranostay <matt@...ostay.sg>,
	Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@...s.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 0/5] Support for Avago APDS9306 Ambient Light Sensor

On Sat, Mar 09, 2024 at 09:20:26PM +1030, Subhajit Ghosh wrote:
> Support for Avago APDS9306 Ambient Light Sensor.
> 
> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
> It has two channels - ALS and CLEAR. The ALS (Ambient Light Sensor)
> channel approximates the response of the human-eye providing direct
> read out where the output count is proportional to ambient light levels.
> It is internally temperature compensated and rejects 50Hz and 60Hz flicker
> caused by artificial light sources. Hardware interrupt configuration is
> optional. It is a low power device with 20 bit resolution and has 
> configurable adaptive interrupt mode and interrupt persistence mode.
> The device also features inbuilt hardware gain, multiple integration time
> selection options and sampling frequency selection options.
> 
> This driver also uses the IIO GTS (Gain Time Scale) Helpers Namespace for 
> Scales, Gains and Integration time implementation.
> 
> Link: https://docs.broadcom.com/doc/AV02-4755EN

..

>  - Removed 'ret' from iio_gts_find_new_gain_by_old_gain_time()
>    as it is not used. The current implementaion of the above
>    function passes all my tests of changing integration times,
>    scales and gains from userspace.

This is weird. I believe we have to fix the API first before adding / dropping
the return value from it. This odd API which makes everybody confused.

-- 
With Best Regards,
Andy Shevchenko