linux-kernel - Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and Power buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9f43ba6-dc4a-4f74-90eb-fdcea323bb3a@quicinc.com>
Date: Mon, 11 Mar 2024 18:03:34 +0800
From: hui liu <quic_huliu@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and
 Power buttons



On 3/6/2024 3:56 PM, Dmitry Baryshkov wrote:
> On Wed, 6 Mar 2024 at 05:02, hui liu <quic_huliu@...cinc.com> wrote:
>>
>>
>>
>> On 3/6/2024 5:20 AM, Konrad Dybcio wrote:
>>>
>>>
>>> On 3/4/24 08:09, Hui Liu via B4 Relay wrote:
>>>> From: Hui Liu <quic_huliu@...cinc.com>
>>>>
>>>> The Volume Down & Power buttons are controlled by the PMIC via
>>>> the PON hardware, and the Volume Up is connected to a PMIC gpio.
>>>>
>>>> Enable the necessary hardware and setup the GPIO state for the
>>>> Volume Up gpio key.
>>>>
>>>> Signed-off-by: Hui Liu <quic_huliu@...cinc.com>
>>>> ---
>>>
>>> [...]
>>>
>>>
>>>> +&pmk8350_pon {
>>>> +    status = "okay";
>>>> +};
>>>
>>> This device is already enabled
>> Hi Konrad,
>>
>> The status is not set in pmk8350.dtsi, so I thought we should set it for
>> "okay" manually. Do you think so?
> 
> What is the default device status if there is no status property?
The default status is okay.
OK, I will update it, remove the status configuration.

Thanks,
Hui
> 
>