linux-kernel - Re: [PATCH 2/3] media: mediatek: vcodec: Improve wording & fix grammatic issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <483ba231-4b7b-44c5-a5b6-c58ec0760407@collabora.com>
Date: Mon, 11 Mar 2024 11:27:56 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Sebastian Fricke <sebastian.fricke@...labora.com>,
 Tiffany Lin <tiffany.lin@...iatek.com>,
 Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
 Yunfei Dong <yunfei.dong@...iatek.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH 2/3] media: mediatek: vcodec: Improve wording & fix
 grammatic issues

Il 09/03/24 16:08, Sebastian Fricke ha scritto:
> Multiple issues detected while scanning the code by far not a complete
> list of required changes but some small improvements.
> 
> Signed-off-by: Sebastian Fricke <sebastian.fricke@...labora.com>
> ---
>   drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h   | 2 +-
>   .../media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c    | 2 +-
>   .../platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c    | 2 +-
>   .../platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c    | 2 +-
>   drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_if.c     | 4 ++--
>   drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c | 2 +-
>   6 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> index a0451116f2e4..f975db4293da 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> @@ -71,7 +71,7 @@ enum mtk_vdec_hw_arch {
>    * @fb_sz: bitstream size of each plane
>    * E.g. suppose picture size is 176x144,
>    *      buffer size will be aligned to 176x160.
> - * @cap_fourcc: fourcc number(may changed when resolution change)
> + * @cap_fourcc: fourcc number(may change on a resolution change)

This goes to patch 1/3

>    * @reserved: align struct to 64-bit in order to adjust 32-bit and 64-bit os.
>    */
>   struct vdec_pic_info {
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c
> index 37c41b673876..668e87bf30e8 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c
> @@ -27,7 +27,7 @@ struct mtk_h264_dec_slice_param {
>   /**
>    * struct vdec_h264_dec_info - decode information
>    * @dpb_sz		: decoding picture buffer size
> - * @resolution_changed  : resolution change happend
> + * @resolution_changed  : flag to notify that a resolution change happend

happend -> happened

>    * @realloc_mv_buf	: flag to notify driver to re-allocate mv buffer
>    * @cap_num_planes	: number planes of capture buffer
>    * @bs_dma		: Input bit-stream buffer dma address
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> index d5224c9584b6..c4ac6b6f7acf 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> @@ -131,7 +131,7 @@ struct vdec_h264_slice_share_info {
>   /**
>    * struct vdec_h264_slice_inst - h264 decoder instance
>    *
> - * @slice_dec_num:	how many picture be decoded
> + * @slice_dec_num:	how many pictures to be decoded

number of frames to be decoded ?

Cheers,
Angelo

>    * @ctx:		point to mtk_vcodec_dec_ctx
>    * @pred_buf:		HW working prediction buffer
>    * @mv_buf:		HW working motion vector buffer
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> index a44db6139ff2..349b510d355a 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> @@ -342,7 +342,7 @@ struct vdec_hevc_slice_share_info {
>   /**
>    * struct vdec_hevc_slice_inst - hevc decoder instance
>    *
> - * @slice_dec_num:      how many picture be decoded
> + * @slice_dec_num:      how many pictures to be decoded
>    * @ctx:                point to mtk_vcodec_dec_ctx
>    * @mv_buf:             HW working motion vector buffer
>    * @vpu:                VPU instance
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_if.c
> index 19407f9bc773..9649f4ec1f2a 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_if.c
> @@ -56,7 +56,7 @@
>    * @cur_c_fb_dma      : current plane C frame buffer dma address
>    * @bs_dma	      : bitstream dma address
>    * @bs_sz	      : bitstream size
> - * @resolution_changed: resolution change flag 1 - changed,  0 - not change
> + * @resolution_changed: resolution change flag 1 - changed,  0 - not changed

This goes to patch [1/3]

>    * @show_frame	      : display this frame or not
>    * @wait_key_frame    : wait key frame coming
>    */
> @@ -109,7 +109,7 @@ struct vdec_vp8_hw_reg_base {
>   /**
>    * struct vdec_vp8_vpu_inst - VPU instance for VP8 decode
>    * @wq_hd	: Wait queue to wait VPU message ack
> - * @signaled	: 1 - Host has received ack message from VPU, 0 - not receive
> + * @signaled	: 1 - Host has received ack message from VPU, 0 - not received

same

>    * @failure	: VPU execution result status 0 - success, others - fail
>    * @inst_addr	: VPU decoder instance address
>    */
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> index f677e499fefa..e27e728f392e 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> @@ -35,7 +35,7 @@
>    * @cur_c_fb_dma:	current plane C frame buffer dma address
>    * @bs_dma:		bitstream dma address
>    * @bs_sz:		bitstream size
> - * @resolution_changed:resolution change flag 1 - changed,  0 - not change
> + * @resolution_changed:resolution change flag 1 - changed,  0 - not changed

ditto

>    * @frame_header_type:	current frame header type
>    * @crc:		used to check whether hardware's status is right
>    * @reserved:		reserved, currently unused
> 

Cheers,
Angelo