[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e828b14c-7a09-479a-bf60-0c16571f133f@quicinc.com>
Date: Mon, 11 Mar 2024 10:27:09 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh+dt@...nel.org>
CC: <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<kernel@...cinc.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name
for match with driver
On 3/10/2024 7:44 AM, Linus Walleij wrote:
> On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@...nel.org> wrote:
>> On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@...nel.org> wrote:
>>> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@...cinc.com> wrote:
>>>>
>>>> Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl"
>>>> to match the compatible name in sm4450 pinctrl driver.
>>>>
>>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>>> ---
>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>> index bb08ca5a1509..bb675c8ec220 100644
>>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>> @@ -17,7 +17,7 @@ allOf:
>>>>
>>>> properties:
>>>> compatible:
>>>> - const: qcom,sm4450-pinctrl
>>>> + const: qcom,sm4450-tlmm
>>>
>>> I think you forgot to update the example:
>>>
>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb:
>>> /example-0/pinctrl@...0000: failed to match any schema with
>>> compatible: ['qcom,sm4450-tlmm']
>>
>> Still a warning in linux-next. Please send a fix.
>
> I understand it as applying 1/2 is the fix so I applied it.
I will check this warning, and I will fix it.
>
> Yours,
> Linus Walleij
--
Thx and BRs,
Tengfei Fan
Powered by blists - more mailing lists