linux-kernel - Re: [PATCH] jffs2: print symbolic error name instead of error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1349276201.40757.1710161787719.JavaMail.zimbra@nod.at>
Date: Mon, 11 Mar 2024 13:56:27 +0100 (CET)
From: Richard Weinberger <richard@....at>
To: Christian Heusel <christian@...sel.eu>
Cc: David Woodhouse <dwmw2@...radead.org>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code

----- Ursprüngliche Mail -----
> Von: "Christian Heusel" <christian@...sel.eu>
> An: "David Woodhouse" <dwmw2@...radead.org>, "richard" <richard@....at>, "linux-mtd" <linux-mtd@...ts.infradead.org>,
> "linux-kernel" <linux-kernel@...r.kernel.org>
> CC: "kernel-janitors" <kernel-janitors@...r.kernel.org>
> Gesendet: Montag, 11. März 2024 13:47:40
> Betreff: Re: [PATCH] jffs2: print symbolic error name instead of error code

> On 24/02/11 01:39AM, Christian Heusel wrote:
>> Utilize the %pe print specifier to get the symbolic error name as a
>> string (i.e "-ENOMEM") in the log message instead of the error code to
>> increase its readablility.
>> 
>> This change was suggested in
>> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>> 
>> Signed-off-by: Christian Heusel <christian@...sel.eu>
>> ---
>>  fs/jffs2/background.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
>> index 6da92ecaf66d..bb0ee1a59e71 100644
>> --- a/fs/jffs2/background.c
>> +++ b/fs/jffs2/background.c
>> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info
>> *c)
>> 
>>  	tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d",
>>  	c->mtd->index);
>>  	if (IS_ERR(tsk)) {
>> -		pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
>> -			-PTR_ERR(tsk));
>> +		pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
>> +			tsk);
>>  		complete(&c->gc_thread_exit);
>>  		ret = PTR_ERR(tsk);
>>  	} else {
>> --
>> 2.43.1
> 
> Friendly ping on the above patch, since it's now a month after sending
> it :)

Thanks for the ping. Your patch looks good. I'll queue it.

Thanks,
//richard