linux-kernel - [PATCH 10/11] arch/alpha/smc37c669.: make SMC37c669_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 11 Mar 2024 14:23:05 +0100
From: Max Kellermann <max.kellermann@...os.com>
To: richard.henderson@...aro.org,
	ink@...assic.park.msu.ru,
	mattst88@...il.com,
	linux-alpha@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Max Kellermann <max.kellermann@...os.com>
Subject: [PATCH 10/11] arch/alpha/smc37c669.: make SMC37c669_dump_registers() static

This function is only used within this source file.  Fixes
`-Wmissing-prototypes`:

 arch/alpha/kernel/smc37c669.c:2434:1: error: no previous prototype for 'SMC37c669_dump_registers' [-Werror=missing-prototypes]
  2434 | SMC37c669_dump_registers(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~

Also add `#if SMC_DEBUG` because it's only ever used under this
condition.

Signed-off-by: Max Kellermann <max.kellermann@...os.com>
---
 arch/alpha/kernel/smc37c669.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/smc37c669.c b/arch/alpha/kernel/smc37c669.c
index bbbd34586de0..ab22ade3dea3 100644
--- a/arch/alpha/kernel/smc37c669.c
+++ b/arch/alpha/kernel/smc37c669.c
@@ -2430,13 +2430,16 @@ int __init smcc669_write( struct FILE *fp, int size, int number, unsigned char *
 }
 #endif
 
-void __init
+#if SMC_DEBUG
+static void __init
 SMC37c669_dump_registers(void)
 {
   int i;
   for (i = 0; i <= 0x29; i++)
     printk("-- CR%02x : %02x\n", i, SMC37c669_read_config(i));
 }
+#endif // SMC_DEBUG
+
 /*+
  * ============================================================================
  * = SMC_init - SMC37c669 Super I/O controller initialization                 =
-- 
2.39.2