linux-kernel - Re: [PATCH 2/2] counter: ti-eqep: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b61b7cd-38c6-456b-aef1-be96c6bff978@lechnology.com>
Date: Mon, 11 Mar 2024 08:57:42 -0500
From: David Lechner <david@...hnology.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 William Breathitt Gray <william.gray@...aro.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@...gutronix.de
Subject: Re: [PATCH 2/2] counter: ti-eqep: Convert to platform remove callback
 returning void

On 3/10/24 3:06 AM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

Acked-by: David Lechner <david@...hnology.com>