linux-kernel - Re: [PATCH] Documentation: power: Fix typo in suspend and interrupts doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240311043927.il77znubaymo3rhd@dhruva>
Date: Mon, 11 Mar 2024 10:09:27 +0530
From: Dhruva Gole <d-gole@...com>
To: Saravana Kannan <saravanak@...gle.com>
CC: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <len.brown@...el.com>,
        Pavel Machek <pavel@....cz>, <kernel-team@...roid.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation: power: Fix typo in suspend and interrupts
 doc

On Mar 08, 2024 at 14:44:50 -0800, Saravana Kannan wrote:
> Typos are bad. Fix them.

Maybe a little more description that you s/by/but would've also made
things more clear?

> 
> Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> ---
>  Documentation/power/suspend-and-interrupts.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/power/suspend-and-interrupts.rst b/Documentation/power/suspend-and-interrupts.rst
> index dfbace2f4600..f588feeecad0 100644
> --- a/Documentation/power/suspend-and-interrupts.rst
> +++ b/Documentation/power/suspend-and-interrupts.rst
> @@ -78,7 +78,7 @@ handling the given IRQ as a system wakeup interrupt line and disable_irq_wake()
>  turns that logic off.
>  
>  Calling enable_irq_wake() causes suspend_device_irqs() to treat the given IRQ
> -in a special way.  Namely, the IRQ remains enabled, by on the first interrupt
> +in a special way.  Namely, the IRQ remains enabled, but on the first interrupt
>  it will be disabled, marked as pending and "suspended" so that it will be
>  re-enabled by resume_device_irqs() during the subsequent system resume.  Also
>  the PM core is notified about the event which causes the system suspend in
> -- 

Anyway, changes LGTM!

Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole <d-gole@...com>