linux-kernel - Re: [PATCH 3/3] sh: Call paging_init() earlier in the init sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 11 Mar 2024 10:02:16 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Oreoluwa Babatunde <quic_obabatun@...cinc.com>
Cc: chenhuacai@...nel.org, jonas@...thpole.se, 
	stefan.kristiansson@...nalahti.fi, shorne@...il.com, 
	ysato@...rs.sourceforge.jp, dalias@...c.org, glaubitz@...sik.fu-berlin.de, 
	frowand.list@...il.com, linux-openrisc@...r.kernel.org, 
	loongarch@...ts.linux.dev, linux-sh@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH 3/3] sh: Call paging_init() earlier in the init sequence

On Fri, Feb 9, 2024 at 5:29 PM Oreoluwa Babatunde
<quic_obabatun@...cinc.com> wrote:
>
> The unflatten_device_tree() function contains a call to
> memblock_alloc(). This is a problem because this allocation is done
> before any of the reserved memory is set aside in paging_init().
> This means that there is a possibility for memblock to allocate from
> any of the memory regions that are supposed to be set aside as reserved.
>
> Hence, move the call to paging_init() to be earlier in the init
> sequence so that the reserved memory regions are set aside before any
> allocations are done using memblock.
>
> Signed-off-by: Oreoluwa Babatunde <quic_obabatun@...cinc.com>
> ---
>  arch/sh/kernel/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@...nel.org>