linux-kernel - Re: [PATCH v2 01/14] x86/sev: Rename snp_init() in the boot/compressed/sev.c file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33b7a57e-1df8-47ee-94d7-aa646a9e923c@amd.com>
Date: Mon, 11 Mar 2024 11:16:47 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
 Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Dan Williams <dan.j.williams@...el.com>, Michael Roth
 <michael.roth@....com>, Ashish Kalra <ashish.kalra@....com>
Subject: Re: [PATCH v2 01/14] x86/sev: Rename snp_init() in the
 boot/compressed/sev.c file

On 3/10/24 16:25, Borislav Petkov wrote:
> On Fri, Mar 08, 2024 at 12:35:16PM -0600, Tom Lendacky wrote:
>> @@ -478,7 +557,7 @@ void sev_enable(struct boot_params *bp)
>>   	 * Setup/preliminary detection of SNP. This will be sanity-checked
>>   	 * against CPUID/MSR values later.
>>   	 */
>> -	snp = snp_init(bp);
>> +	snp = snp_setup(bp);
> 
> So if you call the compressed/sev.c version early_snp_init() or
> boot_snp_init() or something similar, you know immediately when it is

Yep, makes sense. Will change it.

Thanks,
Tom

> called vs having to grep the tree to figure out which is which - was
> snp_setup() early or was it in the kernel proper.  And so on...
>