linux-kernel - Re: [BUG net-next] fcnal-test.sh: 4 (four) tests FAIL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <685a957d-5ce4-4165-aa6d-71570866b9d4@gmail.com>
Date: Mon, 11 Mar 2024 10:26:56 -0600
From: David Ahern <dsahern@...il.com>
To: Jakub Kicinski <kuba@...nel.org>,
 Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
Cc: netdev@...r.kernel.org, Guillaume Nault <gnault@...hat.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG net-next] fcnal-test.sh: 4 (four) tests FAIL

On 3/11/24 10:17 AM, Jakub Kicinski wrote:
> On Sat, 9 Mar 2024 19:45:15 +0100 Mirsad Todorovac wrote:
>> In the vanilla net-next tree build of v6.8-rc7-2348-g75c2946db360, with up-to-date
>> iproute2 built tools, fcnal-test.sh reports certain failures:
>>
>> --------------------------------------------------------------------------------------
>> # TEST: ping local, VRF bind - VRF IP                                           [FAIL]
>> # TEST: ping local, device bind - ns-A IP                                       [FAIL]
>> # TEST: ping local, VRF bind - VRF IP                                           [FAIL]
>> # TEST: ping local, device bind - ns-A IP                                       [FAIL]
>> --------------------------------------------------------------------------------------
> 
> Adding David A to CC.
> 
> It rings a bell. We also build ping from source when running the tests
> locally, I have in my notes "AWS iputils are buggy, use iputils.git"
> but unfortunately I didn't make a note which tests were failing without
> it. David might remember..

yes, please update ping -- make sure it has proper support for
SO_BINDTODEVICE.

It's a bug in versions of iputils ping. It sets the BINDTODEVICE and
then resets it because the source address is not set on the command line
(it should not be required - they are separate intents).