linux-kernel - Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4936c555-2c53-d421-126c-48804a26887d@inria.fr>
Date: Mon, 11 Mar 2024 18:05:41 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: "Felix N. Kimbu" <felixkimbu1@...il.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, 
    outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: cfg80211: Remove parentheses
 prism2_get_station



On Mon, 11 Mar 2024, Felix N. Kimbu wrote:

> Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
> in static int prism2_get_station(...)

You don't need the name of the function in the subject line.  That
information doesn't help understand the patch.

julia


>
> This change ensures adherence to coding style guidelines.
>
> Signed-off-by: Felix N. Kimbu <felixkimbu1@...il.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 471bb310176f..7451fd2bb580 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>
>  	memset(sinfo, 0, sizeof(*sinfo));
>
> -	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> +	if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
>  		return -EOPNOTSUPP;
>
>  	/* build request message */
> --
> 2.34.1
>
>
>