linux-kernel - Re: [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240311052651.uedxt2wvywqlrsac@dhruva>
Date: Mon, 11 Mar 2024 10:56:51 +0530
From: Dhruva Gole <d-gole@...com>
To: Viresh Kumar <viresh.kumar@...aro.org>
CC: Sibi Sankar <quic_sibis@...cinc.com>, <dietmar.eggemann@....com>,
        <rafael@...nel.org>, <xuwei5@...ilicon.com>, <zhanjie9@...ilicon.com>,
        <sudeep.holla@....com>, <cristian.marussi@....com>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <quic_rgottimu@...cinc.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using
 cpufreq_boost_set_sw

Hi,

On Mar 11, 2024 at 10:20:44 +0530, Viresh Kumar wrote:
> On 08-03-24, 16:06, Sibi Sankar wrote:
> > +		/* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
> > +		if (cpufreq_driver->boost_enabled)
> > +			policy->boost_enabled = policy_has_boost_freq(policy) ? true : false;
> 
> Can be written as:
> 
> policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);

I would like to recommend the same.

> 
> Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>

Rest looks fine,
Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole <d-gole@...com>