linux-kernel - Re: [PATCH bpf-next] bpf: fix oob in btf_name_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b618a33551a0fe0ef5d74b9dc5399afca52209c.camel@gmail.com>
Date: Mon, 11 Mar 2024 20:28:52 +0200
From: Eduard Zingerman <eddyz87@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Edward Adam Davis <eadavis@...com>, 
 syzbot+cc32304f6487ebff9b70@...kaller.appspotmail.com, andrii@...nel.org, 
 ast@...nel.org, bpf@...r.kernel.org, daniel@...earbox.net,
 haoluo@...gle.com,  john.fastabend@...il.com, jolsa@...nel.org,
 kpsingh@...nel.org,  linux-kernel@...r.kernel.org, martin.lau@...ux.dev,
 netdev@...r.kernel.org,  sdf@...gle.com, song@...nel.org,
 syzkaller-bugs@...glegroups.com,  yonghong.song@...ux.dev
Subject: Re: [PATCH bpf-next] bpf: fix oob in btf_name_valid_section

On Mon, 2024-03-11 at 11:01 -0700, Andrii Nakryiko wrote:
[...]

> Eduard, I'd also say we should make __btf_name_valid() a bit more
> uniform by dropping that first if and then doing
> 
> if (!__btf_name_char_ok(*src, src == src_orig))
>     return false;
> 
> where we just remember original string pointer in src_orig.
> 
> WDYT?

Agree, this looks simpler.