linux-kernel - Re: [PATCH v5 02/10] locking/mutex: introduce devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7147fb3-fbe1-4063-823d-31f77b8ac801@csgroup.eu>
Date: Tue, 12 Mar 2024 05:41:48 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: George Stark <gnstark@...utedevices.com>, Andy Shevchenko
	<andy.shevchenko@...il.com>
CC: "pavel@....cz" <pavel@....cz>, "lee@...nel.org" <lee@...nel.org>,
	"vadimp@...dia.com" <vadimp@...dia.com>, "mpe@...erman.id.au"
	<mpe@...erman.id.au>, "npiggin@...il.com" <npiggin@...il.com>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>, "mazziesaccount@...il.com"
	<mazziesaccount@...il.com>, "peterz@...radead.org" <peterz@...radead.org>,
	"mingo@...hat.com" <mingo@...hat.com>, "will@...nel.org" <will@...nel.org>,
	"longman@...hat.com" <longman@...hat.com>, "boqun.feng@...il.com"
	<boqun.feng@...il.com>, "nikitos.tr@...il.com" <nikitos.tr@...il.com>,
	"kabel@...nel.org" <kabel@...nel.org>, "linux-leds@...r.kernel.org"
	<linux-leds@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org"
	<linuxppc-dev@...ts.ozlabs.org>, "kernel@...utedevices.com"
	<kernel@...utedevices.com>
Subject: Re: [PATCH v5 02/10] locking/mutex: introduce devm_mutex_init



Le 12/03/2024 à 01:01, George Stark a écrit :
> [Vous ne recevez pas souvent de courriers de gnstark@...utedevices.com. 
> Découvrez pourquoi ceci est important à 
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hello Andy
> 
> On 3/7/24 13:34, Andy Shevchenko wrote:
>> On Thu, Mar 7, 2024 at 4:40 AM George Stark 
>> <gnstark@...utedevices.com> wrote:
>>>
>>> Using of devm API leads to a certain order of releasing resources.
>>> So all dependent resources which are not devm-wrapped should be deleted
>>> with respect to devm-release order. Mutex is one of such objects that
>>> often is bound to other resources and has no own devm wrapping.
>>> Since mutex_destroy() actually does nothing in non-debug builds
>>> frequently calling mutex_destroy() is just ignored which is safe for now
>>> but wrong formally and can lead to a problem if mutex_destroy() will be
>>> extended so introduce devm_mutex_init()
>>>
>>> Signed-off-by: George Stark <gnstark@...utedevices.com>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
>>
>>>   Hello Christophe. Hope you don't mind I put you SoB tag because you 
>>> helped alot
>>>   to make this patch happen.
>>
>> You also need to figure out who should be the author of the patch and
>> probably add a (missing) Co-developed-by. After all you should also
>> follow the correct order of SoBs.
>>
> 
> Thanks for the review.
> I explained in the other letter as I see it. So I'd leave myself
> as author and add appropriate tag with Christophe's name.
> BTW what do you mean by correct SoB order?
> Is it alphabetical order or order of importance?
> 

The correct order is to first have the Author's SoB.