[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM9d7ciP5HJP__Hoh70q5F2drCwtyqzSmvLzMS06dvkYeVu2-g@mail.gmail.com>
Date: Mon, 11 Mar 2024 23:49:07 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: weilin.wang@...el.com
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
Perry Taylor <perry.taylor@...el.com>, Samantha Alt <samantha.alt@...el.com>,
Caleb Biggers <caleb.biggers@...el.com>
Subject: Re: [RFC PATCH v3 5/6] perf stat: Add retire latency print functions
to print out at the very end of print out
On Fri, Mar 1, 2024 at 4:11 PM <weilin.wang@...el.com> wrote:
>
> From: Weilin Wang <weilin.wang@...el.com>
>
> Add print out functions so that users could read retire latency values.
Can you please put some example output here?
Thanks,
Namhyung
>
> Signed-off-by: Weilin Wang <weilin.wang@...el.com>
> ---
> tools/perf/util/stat-display.c | 65 ++++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index bfc1d705f437..e2996ba67bfe 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -21,6 +21,7 @@
> #include "iostat.h"
> #include "pmu.h"
> #include "pmus.h"
> +#include "metricgroup.h"
>
> #define CNTR_NOT_SUPPORTED "<not supported>"
> #define CNTR_NOT_COUNTED "<not counted>"
> @@ -34,6 +35,7 @@
> #define COMM_LEN 16
> #define PID_LEN 7
> #define CPUS_LEN 4
> +#define RETIRE_LEN 8
>
> static int aggr_header_lens[] = {
> [AGGR_CORE] = 18,
> @@ -426,6 +428,67 @@ static void print_metric_std(struct perf_stat_config *config,
> fprintf(out, " %-*s", METRIC_LEN - n - 1, unit);
> }
>
> +static void print_retire_lat_std(struct perf_stat_config *config,
> + struct outstate *os)
> +{
> + FILE *out = os->fh;
> + bool newline = os->newline;
> + struct tpebs_retire_lat *t;
> + struct list_head *retire_lats = &config->tpebs_results;
> +
> + list_for_each_entry(t, retire_lats, nd) {
> + if (newline)
> + do_new_line_std(config, os);
> + fprintf(out, "%'*.2f %-*s", COUNTS_LEN, t->val, EVNAME_LEN, t->name);
> + fprintf(out, "%*ld %*d\n", RETIRE_LEN, t->count,
> + RETIRE_LEN, t->sum);
> + }
> +}
> +
> +static void print_retire_lat_csv(struct perf_stat_config *config,
> + struct outstate *os)
> +{
> + FILE *out = os->fh;
> + struct tpebs_retire_lat *t;
> + struct list_head *retire_lats = &config->tpebs_results;
> + const char *sep = config->csv_sep;
> +
> + list_for_each_entry(t, retire_lats, nd) {
> + fprintf(out, "%f%s%s%s%s%ld%s%d\n", t->val, sep, sep, t->name, sep,
> + t->count, sep, t->sum);
> + }
> +}
> +
> +static void print_retire_lat_json(struct perf_stat_config *config,
> + struct outstate *os)
> +{
> + FILE *out = os->fh;
> + struct tpebs_retire_lat *t;
> + struct list_head *retire_lats = &config->tpebs_results;
> +
> + fprintf(out, "{");
> + list_for_each_entry(t, retire_lats, nd) {
> + fprintf(out, "\"retire_latency-value\" : \"%f\", ", t->val);
> + fprintf(out, "\"event-name\" : \"%s\"", t->name);
> + fprintf(out, "\"sample-counts\" : \"%ld\"", t->count);
> + fprintf(out, "\"retire_latency-sum\" : \"%d\"", t->sum);
> + }
> + fprintf(out, "}");
> +}
> +
> +static void print_retire_lat(struct perf_stat_config *config,
> + struct outstate *os)
> +{
> + if (!&config->tpebs_results)
> + return;
> + if (config->json_output)
> + print_retire_lat_json(config, os);
> + else if (config->csv_output)
> + print_retire_lat_csv(config, os);
> + else
> + print_retire_lat_std(config, os);
> +}
> +
> static void new_line_csv(struct perf_stat_config *config, void *ctx)
> {
> struct outstate *os = ctx;
> @@ -1609,6 +1672,8 @@ void evlist__print_counters(struct evlist *evlist, struct perf_stat_config *conf
> break;
> }
>
> + print_retire_lat(config, &os);
> +
> print_footer(config);
>
> fflush(config->output);
> --
> 2.43.0
>
Powered by blists - more mailing lists