linux-kernel - Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVvmN2xns_76zSDpUX-v8V16mSP12A=Y4gght9cdgNb+A@mail.gmail.com>
Date: Tue, 12 Mar 2024 09:17:54 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Andy Shevchenko <andy@...nel.org>, Paul Burton <paulburton@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel@...gutronix.de
Subject: Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform remove
 callback returning void

Hi Uwe,

On Mon, Mar 11, 2024 at 10:59 PM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for your patch!

> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
>   *
>   * Return: 0

Please remove this line.

>   */
> -static int img_ascii_lcd_remove(struct platform_device *pdev)
> +static void img_ascii_lcd_remove(struct platform_device *pdev)
>  {
>         struct img_ascii_lcd_ctx *ctx = platform_get_drvdata(pdev);
>
>         sysfs_remove_link(&pdev->dev.kobj, "message");
>         linedisp_unregister(&ctx->linedisp);
> -       return 0;
>  }
>
>  static struct platform_driver img_ascii_lcd_driver = {
> @@ -294,7 +293,7 @@ static struct platform_driver img_ascii_lcd_driver = {
>                 .of_match_table = img_ascii_lcd_matches,
>         },
>         .probe  = img_ascii_lcd_probe,
> -       .remove = img_ascii_lcd_remove,
> +       .remove_new = img_ascii_lcd_remove,
>  };
>  module_platform_driver(img_ascii_lcd_driver);

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds