linux-kernel - Re: [PATCH] staging: p80211conv: Rename local foo to decrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ae5c6f0-dfb3-4c98-9798-8379f6206256@moroto.mountain>
Date: Tue, 12 Mar 2024 12:01:14 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Alison Schofield <alison.schofield@...el.com>
Cc: "Felix N. Kimbu" <felixkimbu1@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check

On Mon, Mar 11, 2024 at 03:46:29PM -0700, Alison Schofield wrote:
> On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote:
> > This change renames the local variable foo to decrypt_check in functions
> > skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive
> > meaning to the identifier.
> 
> 'rc' is typically used for cases like this. If the name of the function
> being called is reasonably intuitive, then 'rc' suffices for the return
> value.
> 
> > 
> > It also indents the parameters to match the the opening parentheses.
> 
> 'Also' signals that this patch is trying to do more than one thing.
> One type of 'thing' per patch please.
> 

The name change did force a re-indent.  The v2 re-indent was wrong too
though.

regards,
dan carpenter