linux-kernel - Re: [PATCH] usb: typec: fusb302: Use common error handling code in fusb302

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfAdzsqXeO/IOY/A@kuha.fi.intel.com>
Date: Tue, 12 Mar 2024 11:18:06 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Günter Röck <linux@...ck-us.net>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	RD Babiera <rdbabiera@...gle.com>, Rob Herring <robh@...nel.org>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Yu Zhe <yuzhe@...china.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: typec: fusb302: Use common error handling code in
 fusb302_probe()

On Fri, Mar 01, 2024 at 05:23:25PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 1 Mar 2024 17:00:23 +0100
> 
> Add a label so that a bit of exception handling can be better reused
> at the end of this function implementation.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/fusb302.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index ef18a448b740..e1e030da1dec 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1741,10 +1741,9 @@ static int fusb302_probe(struct i2c_client *client)
> 
>  	chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
>  	if (IS_ERR(chip->tcpm_port)) {
> -		fwnode_handle_put(chip->tcpc_dev.fwnode);
>  		ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
>  				    "cannot register tcpm port\n");
> -		goto destroy_workqueue;
> +		goto put_fwnode;
>  	}
> 
>  	ret = request_irq(chip->gpio_int_n_irq, fusb302_irq_intn,
> @@ -1761,6 +1760,7 @@ static int fusb302_probe(struct i2c_client *client)
> 
>  tcpm_unregister_port:
>  	tcpm_unregister_port(chip->tcpm_port);
> +put_fwnode:
>  	fwnode_handle_put(chip->tcpc_dev.fwnode);
>  destroy_workqueue:
>  	fusb302_debugfs_exit(chip);
> --
> 2.44.0

-- 
heikki