linux-kernel - Re: [PATCH net-next v3 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 12 Mar 2024 10:46:51 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>, Jiri Pirko <jiri@...nulli.us>,
  Ivan Vecera <ivecera@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Andrew Lunn <andrew@...n.ch>,  Eric Dumazet <edumazet@...gle.com>, Florian
 Fainelli <f.fainelli@...il.com>, Jakub Kicinski <kuba@...nel.org>, 
 Vladimir Oltean <olteanv@...il.com>
Cc: Simon Horman <horms@...nel.org>, kernel@...gutronix.de, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/1] net: bridge: switchdev: Improve error
 message clarity for switchdev_port_obj_add/del_deffered operations

On Tue, 2024-03-12 at 10:43 +0100, Paolo Abeni wrote:
> On Sat, 2024-03-09 at 07:32 +0100, Oleksij Rempel wrote:
> > Enhance the error reporting mechanism in the switchdev framework to
> > provide more informative and user-friendly error messages.
> > 
> > Following feedback from users struggling to understand the implications
> > of error messages like "failed (err=-28) to add object (id=2)", this
> > update aims to clarify what operation failed and how this might impact
> > the system or network.
> > 
> > With this change, error messages now include a description of the failed
> > operation, the specific object involved, and a brief explanation of the
> > potential impact on the system. This approach helps administrators and
> > developers better understand the context and severity of errors,
> > facilitating quicker and more effective troubleshooting.
> > 
> > Example of the improved logging:
> > 
> > [   70.516446] ksz-switch spi0.0 uplink: Failed to add Port Multicast
> >                Database entry (object id=2) with error: -ENOSPC (-28).
> > [   70.516446] Failure in updating the port's Multicast Database could
> >                lead to multicast forwarding issues.
> > [   70.516446] Current HW/SW setup lacks sufficient resources.
> > 
> > This comprehensive update includes handling for a range of switchdev
> > object IDs, ensuring that most operations within the switchdev framework
> > benefit from clearer error reporting.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > Reviewed-by: Simon Horman <horms@...nel.org>
> 
> Very minor nit: the reviewed-by tag should come first it that has been
> collected before posting the given revision.

Oops, I almost forgot another very minor nit: a shorter patch title
would be better, ideally fitting 72 chars.

Cheers,

Paolo