linux-kernel - Re: [PATCH] usb: typec: stusb160x: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfArD+j5+CwyDBeb@kuha.fi.intel.com>
Date: Tue, 12 Mar 2024 12:14:39 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Bo Liu <liubo03@...pur.com>
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: stusb160x: convert to use maple tree
 register cache

On Sat, Mar 09, 2024 at 02:17:57AM -0500, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/stusb160x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index 3ab118df1bd4..f3140fc04c12 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -234,7 +234,7 @@ static const struct regmap_config stusb1600_regmap_config = {
>  	.readable_reg	= stusb160x_reg_readable,
>  	.volatile_reg	= stusb160x_reg_volatile,
>  	.precious_reg	= stusb160x_reg_precious,
> -	.cache_type	= REGCACHE_RBTREE,
> +	.cache_type	= REGCACHE_MAPLE,
>  };
>  
>  static bool stusb160x_get_vconn(struct stusb160x *chip)
> -- 
> 2.18.2

-- 
heikki