linux-kernel - Re: [PATCH v1] usb: typec: tcpm: Correct port source pdo array in pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfAtfPciw8O6A+uS@kuha.fi.intel.com>
Date: Tue, 12 Mar 2024 12:25:00 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Kyle Tso <kyletso@...gle.com>
Cc: linux@...ck-us.net, gregkh@...uxfoundation.org, badhri@...gle.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Correct port source pdo array in
 pd_set callback

On Mon, Mar 11, 2024 at 10:45:00PM +0800, Kyle Tso wrote:
> In tcpm_pd_set, the array of port source capabilities is port->src_pdo,
> not port->snk_pdo.
> 
> Fixes: cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")
> Cc: stable@...r.kernel.org
> Signed-off-by: Kyle Tso <kyletso@...gle.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 3d505614bff1..9485f6373de4 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6858,7 +6858,7 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
>  
>  	if (data->source_desc.pdo[0]) {
>  		for (i = 0; i < PDO_MAX_OBJECTS && data->source_desc.pdo[i]; i++)
> -			port->snk_pdo[i] = data->source_desc.pdo[i];
> +			port->src_pdo[i] = data->source_desc.pdo[i];
>  		port->nr_src_pdo = i + 1;
>  	}
>  
> -- 
> 2.44.0.278.ge034bb2e1d-goog

-- 
heikki