linux-kernel - [PATCH] rcu-tasks: Remove unnecessary lazy_jiffies in call_rcu_tasks_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240312113524.7654-1-qiang.zhang1211@gmail.com>
Date: Tue, 12 Mar 2024 19:35:24 +0800
From: Zqiang <qiang.zhang1211@...il.com>
To: paulmck@...nel.org,
	frederic@...nel.org,
	neeraj.upadhyay@...nel.org,
	joel@...lfernandes.org
Cc: qiang.zhang1211@...il.com,
	rcu@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] rcu-tasks: Remove unnecessary lazy_jiffies in call_rcu_tasks_generic_timer()

The rcu_tasks_percpu structure's->lazy_timer is queued only when
the rcu_tasks structure's->lazy_jiffies is not equal to zero in
call_rcu_tasks_generic(), if the lazy_timer callback is invoked,
that means the lazy_jiffes is not equal to zero, this commit
therefore remove lazy_jiffies check in call_rcu_tasks_generic_timer().

Signed-off-by: Zqiang <qiang.zhang1211@...il.com>
---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index b1254cf3c210..439e0b9a2656 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -299,7 +299,7 @@ static void call_rcu_tasks_generic_timer(struct timer_list *tlp)
 
 	rtp = rtpcp->rtpp;
 	raw_spin_lock_irqsave_rcu_node(rtpcp, flags);
-	if (!rcu_segcblist_empty(&rtpcp->cblist) && rtp->lazy_jiffies) {
+	if (!rcu_segcblist_empty(&rtpcp->cblist)) {
 		if (!rtpcp->urgent_gp)
 			rtpcp->urgent_gp = 1;
 		needwake = true;
-- 
2.17.1