linux-kernel - RE: [EXTERNAL] Re: [net PATCH 1/5] octeontx2: Detect the mbox up or down message via register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 12 Mar 2024 11:49:23 +0000
From: Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        Naveen Mamindlapalli <naveenm@...vell.com>,
        "horms@...nel.org" <horms@...nel.org>
Subject: RE: [EXTERNAL] Re: [net PATCH 1/5] octeontx2: Detect the mbox up or
 down message via register

Hi,

>-----Original Message-----
>From: Paolo Abeni <pabeni@...hat.com>
>Sent: Tuesday, March 12, 2024 4:52 PM
>To: Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
>netdev@...r.kernel.org; linux-kernel@...r.kernel.org
>Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; Sunil
>Kovvuri Goutham <sgoutham@...vell.com>; Linu Cherian
><lcherian@...vell.com>; Geethasowjanya Akula <gakula@...vell.com>;
>Hariprasad Kelam <hkelam@...vell.com>; Naveen Mamindlapalli
><naveenm@...vell.com>; horms@...nel.org
>Subject: [EXTERNAL] Re: [net PATCH 1/5] octeontx2: Detect the mbox up or
>down message via register
>
>On Tue, 2024-03-12 at 00:46 +0530, Subbaraya Sundeep wrote:
>> +bool otx2_mbox_wait_for_zero(struct otx2_mbox *mbox, int devid)
>> +{
>> +	u64 data;
>> +
>> +	data = readq((void __iomem *)mbox->reg_base +
>> +		     (mbox->trigger | (devid << mbox->tr_shift)));
>> +
>> +	/* If data is non-zero wait for ~1ms and return to caller
>> +	 * whether data has changed to zero or not after the wait.
>> +	 */
>> +
>> +	if (data)
>> +		usleep_range(950, 1000);
>> +	else
>> +		return true;
>
>Since you have to repost,
>
>	if (!data)
>		return true;
>
>	usleep_range(950, 1000);
>
>
>will be more readable
>
>
Sure will change as per your suggestion.

>Side note: this quite huge for a 'net' patch: it would be nice (but not
>mandatory) if you could break it in smaller pieces or consider a 'net-
>next' target. In the latter case, please note that 'net-next' is
>currently closed for the merge window.
>
Actually I thought of breaking into smaller pieces before but all this changes are needed for basic
mbox functionality hence used a single patch. I am fixing mbox communication errors with a design change so assumed
it as net material. Please let me know if you still want to be a net-next patch.

Thanks,
Sundeep

>Cheers,
>
>Paolo