linux-kernel - Re: [PATCH v2] mtd: spi-nor: core: correct type of i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 12 Mar 2024 13:14:03 +0100
From: Pratyush Yadav <pratyush@...nel.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <mwalle@...nel.org>,  Miquel Raynal
 <miquel.raynal@...tlin.com>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>,  Takahiro Kuwano
 <Takahiro.Kuwano@...ineon.com>,  kernel@...labora.com,
  kernel-janitors@...r.kernel.org,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: core: correct type of i

Hi,

On Mon, Mar 11 2024, Muhammad Usama Anjum wrote:

> Soft reminder

Miquel should pick up the patch when sending out his pull request [0].

[0] https://lore.kernel.org/linux-mtd/20240307180919.4cb7a4cb@xps-13/

>
> On 3/4/24 2:01 PM, Muhammad Usama Anjum wrote:
>> The i should be signed to find out the end of the loop. Otherwise,
>> i >= 0 is always true and loop becomes infinite. Make its type to be
>> int.
>> 
>> Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>> ---
>> Changes since v1:
>> - Make i int instead of u8
>> ---
>>  drivers/mtd/spi-nor/core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>> index 65b32ea59afc6..3e1f1913536bf 100644
>> --- a/drivers/mtd/spi-nor/core.c
>> +++ b/drivers/mtd/spi-nor/core.c
>> @@ -3373,7 +3373,7 @@ static u32
>>  spi_nor_get_region_erasesize(const struct spi_nor_erase_region *region,
>>  			     const struct spi_nor_erase_type *erase_type)
>>  {
>> -	u8 i;
>> +	int i;
>>  
>>  	if (region->overlaid)
>>  		return region->size;

-- 
Regards,
Pratyush Yadav